Skip to content

Nerf mining more #82807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Nerf mining more #82807

wants to merge 2 commits into from
+53 −6

Conversation

RenechCDDA
Copy link
Member

Summary

Balance "Massively increase mining time"

Purpose of change

The parts of #82757 which I pushed out.

Describe the solution

Massively increase mining time. 30 minutes ---> 2 hours for jackhammers (remember: no walls!), or 8 hours for pickaxes.

Increment map damage every 5 minutes when doing mining activities, If the activity is interrupted for any reason, that map damage stays and is 'credited' towards mining time when resuming the activity.

Show map damage in the look around menu, so that there is some indication of this. (Also works for bashing and other sources of map damage. Features!)

image image-1

Describe alternatives you've considered

Andrei8l suggested migrating mining to be entirely construction, but I am not convinced the overhead to do that is in any way reasonable. This is much simpler and accomplishes essentially the same thing.

Testing

Needs some. Draft until then

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 8, 2025
@andrei8l
Copy link
Contributor

This is much simpler and accomplishes essentially the same thing.

Map damage is not serialized so this does not, in fact, accomplish the same thing.

but I am not convinced the overhead to do that is in any way reasonable

As it turns out, most of it has already been done. Start here

Cataclysm-DDA/data/json/deconstruction.json

Lines 232 to 244 in ca8f492

{
"type": "construction",
"id": "constr_remove_concrete_wall",
"group": "remove_concrete_wall",
"//": "Cuts a segment of concrete wall out very neatly, and then breaks it apart for disposal.",
"category": "DECONSTRUCT",
"required_skills": [ [ "fabrication", 6 ] ],
"time": "120 m",
"using": [ [ "concrete_removal_standard", 1 ] ],
"byproducts": [ { "item": "rock", "count": [ 20, 44 ] } ],
"pre_terrain": "t_concrete_wall",
"post_terrain": "t_thconc_floor"
},

So you're now in the same situation as with digging a few years ago - there are 2 systems that do the same thing with different mechanics and balance.

// As an added bonus, this also allows mixing and matching of smashing and mining.

This only makes sense if the goal is destruction, not recovery of materials.

@Zerdocriil
Copy link

why do you take this amount of time for new mining values? do you have any examples for it? And different terrain need different time to be mined. dirt easily to mine, stone harder, steel and concrete more harder

@github-actions GitHub Actions
Copy link
Contributor

Hi @Zerdocriil, welcome to CleverRaven! We see that this is your first time commenting here. Check out how development works and be sure to follow the code of conduct! We hope to see you around!

@RenechCDDA
Copy link
Member Author

why do you take this amount of time for new mining values? do you have any examples for it? And different terrain need different time to be mined. dirt easily to mine, stone harder, steel and concrete more harder

This is the generous data from the linked PR.

@Light-Wave
Copy link
Contributor

Keep in mind that weariness might increase the actual time it takes significantly.

@Consoleable
Copy link
Contributor

Consoleable commented Oct 15, 2025 •
edited
Loading

Keep in mind that weariness might increase the actual time it takes significantly.

I think this is a really important point for future PR's of many stripes. If we get some data to say "Activity X takes Y time IRL", well, that IRL time probably factors in weariness for people doing the activity, because the people reporting those times to make the data probably slowed down as they work.
There should be a burden of testing to see if the time that the activity actually takes in game matches the time intended, otherwise, weariness is effectively being applied twice. This is a really good point, independent of this discussion.

@RenechCDDA
Copy link
Member Author

RenechCDDA commented Oct 15, 2025 •
edited
Loading

There should be a burden of testing to see if the time that the activity actually takes in game matches the time intended

There already is. That's why this has been sitting in draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RenechCDDA @andrei8l @Zerdocriil @Light-Wave @Consoleable